Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new restart_simulator.x code #3040

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Conversation

bena-nasa
Copy link
Collaborator

@bena-nasa bena-nasa commented Sep 19, 2024

This is complementary code to the existing checkpoint_simulator.x, and as the name suggests something to mimic the restart reading of cubed-sphere fields. Laura Carriere wants an intern to do some IO benchmarking. They had been running ExtDataDriver.x, but for the restarts, the checkpoint_simulator.x provides finer grained detail and is the better tool. I had started creating restart_simulator.x so this was impetus to finish it so they can test both read and write with this. Like the checkpoint code it has similar options to play with the number of readers and the number of trials. Once this is in I will provide instructions to the intern on how to run the checkpoint_simulator.x, followed by the restart_simulator.x. For now you have to tell in the input file the resolution, number of levels, and number of variables. This could be detected in a future enhancement.

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) labels Sep 19, 2024
@bena-nasa bena-nasa requested a review from a team as a code owner September 19, 2024 18:30
tclune
tclune previously approved these changes Sep 19, 2024
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I like HConfig for GEOS over using something like fArgParse, it is too bad that it does not have an equivalent of "-h" to give the options at the command line.

Might be worth some investment to do something along those lines. @mathomp4

@mathomp4 mathomp4 merged commit e600653 into develop Sep 20, 2024
34 of 36 checks passed
@mathomp4 mathomp4 deleted the feature/bmauer/restart_simulator branch September 23, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 🎁 New Feature This is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants